Handle unset fields in probes set by container-overrides #1169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates how probes (readiness, liveness, startup) are handled when defined in container-overrides. Since fields for success/failure threshold, period, and timeout are defaulted by the cluster, we have to make sure they're either set to user-provided values or the defaults to avoid repeatedly reconciling the deployment yaml
What issues does this PR fix or reference?
Closes #1093
Is it tested? How?
To test, you can use the workspace
This workspace should start normally with defaulted fields for the probes.
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-path
to trigger)v8-devworkspace-operator-e2e
: DevWorkspace e2e testv8-che-happy-path
: Happy path for verification integration with Che